xdamman / mediumexporter

Export your stories published on medium.com to markdown for easy import
MIT License
233 stars 32 forks source link

Fix issue if mediumURL ends with # #12

Closed asameshimae closed 5 years ago

asameshimae commented 6 years ago

If mediumURL ends with a hash it won't be removed by /#.+$/, then +'...#?format=json' will not receive json data.

PatrickHeneise commented 5 years ago

@asameshimae Thanks for the contribution. Could you resolve the conflict, then I can merge this?

codecov-io commented 5 years ago

Codecov Report

Merging #12 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #12   +/-   ##
======================================
  Coverage    8.67%   8.67%           
======================================
  Files           2       2           
  Lines         265     265           
======================================
  Hits           23      23           
  Misses        242     242
Impacted Files Coverage Δ
lib/utils.js 8.9% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27661f6...b64f67f. Read the comment docs.