search

xdamman / selection-sharer

Medium like popover menu to share on Twitter or by email any text selected on the page
MIT License
509 stars 104 forks source link

Not supported in Firefox 36.0 #10

Closed davidholtz closed 9 years ago

davidholtz commented 9 years ago

Awesome work here. I don't see a pop up when highlighting in Firefox. Not sure if you tested there or not.

kiwimind commented 9 years ago

Using the demo page (http://xdamman.github.io/selection-sharer/lib/selection-sharer/demos/demo.html), selecting text in Firefox (37.0.2 here), the following error is logged in the console:

TypeError: selection is undefined

This is on line 141.

kiwimind commented 9 years ago

Apologies, while this doesn't work on the demo page, it does work when using the latest codebase.

Thank you.

davidholtz commented 9 years ago

That's great! I can't wait to test it out. Thanks for the reply.