search

xdamman / selection-sharer

Medium like popover menu to share on Twitter or by email any text selected on the page
MIT License
510 stars 104 forks source link

[Bug] Clicking outside of <p> elements doesn't close popup #11

Open turshija opened 9 years ago

turshija commented 9 years ago

For example I highlight a text in elements I've chosen, popup shows and if I click outside (for example on background), text gets de-selected but popup remains.

Image

neuedeutsche commented 9 years ago

yup noticed that too, needs a more general close event.

dandv commented 9 years ago

Screencast

icon persists after clicking elsewhere

dandv commented 9 years ago

Fixed in my fork of SelectionMenu that addresses a few other issues from selection-sharer and makes it general-purpose (i.e you can put anything you want in the menu).