search

xdamman / selection-sharer

Medium like popover menu to share on Twitter or by email any text selected on the page
MIT License
509 stars 104 forks source link

Facebook #5

Open hansvangent opened 9 years ago

hansvangent commented 9 years ago

Tried the new Facebook code, and even though I have og tags it still shows me the message: "This page does not have a valid Facebook Open Graph Meta tags". You've seen this happening as well?

xdamman commented 9 years ago

How have you tested? Facebook needs to be able to load your page so it won't work if you test on localhost

hansvangent commented 9 years ago

Tested it on my live environment, Facebook debugger says everything is okay: https://developers.facebook.com/tools/debug/og/object?q=http%3A%2F%2Fjcvangent.com%2Fcustomer-development-stop-wasting-time%2F

But on the page itself it is not working ( http://jcvangent.com/customer-development-stop-wasting-time/ ), maybe there could be a check that if for whatever reason it is not working, or it thinks it is not working (thus returning the console.log error) that the Facebook sharer is not included in the pop-over or pop-under?

AlienSKP commented 9 years ago

Sorry I'm gonna fix this. I'm working on it right now.

hansvangent commented 9 years ago

Ok cool, let me know if you want me to test something!

AlienSKP commented 9 years ago

OK I get it now. @jcvangent a app ID facebook meta is needed in my script.

@xdamman "Facebook share" page requires a Facebook App ID to run so I was checking the meta to retrieve content value of "fb:app_id" meta tag.

I'm going to ensure this tag is in the page before displaying the facebook share button, ok ?

hansvangent commented 9 years ago

Sounds like a great solution!

AlienSKP commented 9 years ago

done :)

hansvangent commented 9 years ago

Awesome!

AlienSKP commented 9 years ago

@jcvangent if you want to test it I've forked it https://github.com/AlienSKP/selection-sharer thanks buddy :+1: