search

xdamman / selection-sharer

Medium like popover menu to share on Twitter or by email any text selected on the page
MIT License
509 stars 104 forks source link

Make the package npm publishable #53

Closed shri3k closed 7 years ago

shri3k commented 7 years ago

Addresses #42

Description

Notes

To run demos just run npm run demo to build bundles for webpack and browserify or run respective scripts specified in package.json.

@xdamman, I believe since you're the owner of the package - I'll let you decide whose name this package should go under. Also, I noticed that this package is named either selection-share or share-selection. At the moment this package is named share-selection according to package.json but the project itself is named selection-sharer. I believe you should publish it as selection-sharer to avoid confusion to former and current users. But it's upto you. :smile_cat:

Let me know if there's anything that needs to be changed in this PR.

xdamman commented 7 years ago

Feel free to publish it under your name. Agreed on keeping the name consistent with the name of the repo. Thanks for the great work!

A really cool thing to do would be to make it as a react component.

shri3k commented 7 years ago

A really cool thing to do would be to make it as a react component.

I think we should have a different repo for that as it might confuse people who are not using react on their project.

shri3k commented 7 years ago

Just an update on the consistent name. I went ahead and named it selection-sharer in npm as well so that it matches the repo name. It's now been published here. :tada:

xdamman commented 7 years ago

react-selection-sharer?

shri3k commented 7 years ago

Yeah, I think the naming convention on react-components should make that obvious.