search

xdamman / selection-sharer

Medium like popover menu to share on Twitter or by email any text selected on the page
MIT License
509 stars 104 forks source link

Removed all jQuery 3.x migration issues. #62

Closed clivewalkden closed 6 years ago

clivewalkden commented 6 years ago

Removed email link target to stop empty window being created. Encoded more of the email body to stop it breaking when ampersand encountered in the document.title or window.location.href

shri3k commented 6 years ago

Just doing some light regression testing in both jQuery 2 and jQuery 3 and looks like it works on both cases - I did of course just performed light testing. I'll drop the link to my testing playground in case anyone else wants to do more testing.

jQuery2 version playground jQuery3 version playground

shri3k commented 6 years ago

Going to merge this as I didn't see much issue with the changes on both version. Thanks @clivewalkden for the PR. :tada: