search

xdamman / selection-sharer

Medium like popover menu to share on Twitter or by email any text selected on the page
MIT License
509 stars 104 forks source link

LinkedIn sharing #8

Closed hansvangent closed 5 years ago

hansvangent commented 9 years ago

LinkedIn sharing added

xdamman commented 9 years ago

Great thanks!

Now that we start having more services, it would be great to have an easy way to choose which ones the user wants. E.g. when we instantiate it:

<script>
$('p').selectionSharer({twitter:true,facebook:true,linkedin:false});
</script>
AlienSKP commented 9 years ago

Yes I was thinking the same. Ill try to do it sometimes tonight or tomorrow On Feb 16, 2015 12:47 PM, "Xavier Damman" notifications@github.com wrote:

Great thanks!

Now that we start having more services, it would be great to have an easy way to choose which ones the user wants. E.g. when we instantiate it:

— Reply to this email directly or view it on GitHub https://github.com/xdamman/selection-sharer/pull/8#issuecomment-74546875 .

hansvangent commented 9 years ago

Cool, was thinking about it too, with some more settings even for the Wordpress plugin like setting your own customer URL shortener etc.

xdamman commented 9 years ago

Sorry, apparently this never got merged. Can you rebase so that it can be merged automatically?

hansvangent commented 9 years ago

What do you mean with rebase it?

xdamman commented 9 years ago

I mean pulling master back into your pull request branch and post it again.

On Jun 23, 2015, at 4:24 PM, Hans van Gent notifications@github.com wrote:

What do you mean with rebase it?

— Reply to this email directly or view it on GitHub.

cmalexander commented 5 years ago

Did LinkedIn ever get added to this? If so, I would love to know how to add it.

shri3k commented 5 years ago

@cmalexander I don't think it ever did due to merge conflict on the PR. I'll see what I can do this evening.

Edit: I went ahead and added the "LinkedIn" share capabilities in feat-linkedin branch now. Feel free to test this until I build a release for it.

shri3k commented 5 years ago

@cmalexander alright. It should be there now. Will probably need to bump the version to 1.1.0 if you're using npm.

shri3k commented 5 years ago

Closing. Feel free to open an issue if there are any for this.

cmalexander commented 5 years ago

Thanks so much @shri3k! Really appreciate it!

cmalexander commented 5 years ago

Hi @shri3k. Thanks again for your help. LinkedIn is appearing, but when I highlight text and select LinkedIn there is no text transferred to the pop-up window. Is there something else I need to do besides include the .js and .css files?

shri3k commented 5 years ago

Hey @cmalexander sorry it took me a while to get to this but LinkedIn and Facebook usually follows Open Graph Protocol and if not found they have their own algorithm to analyze and display what's on the page that you're sharing. This is however a bit different in Twitter where they share exactly what you selected.

That said, you can control what LinkedIn and other media sharing platform displays by adding few OGP tags. Facebook Open Graph LinkedIn Open Graph - scroll down to "Improve content sharing with Open Graph"

Hope that helps.