[ ] There is an associated issue that is labelled 'Bug' or 'help wanted' or is in the Community milestone
[x] Code is up-to-date with the master branch
[x] You've successfully run npm test locally
[ ] There are new or updated tests validating the change
Fixes
For an upgrade to jQuery 3.5.1, using the migration plugin a couple of errors was thrown when running in QA env.
This fork was created in anticipation of an update that would fix this issue, if this is not on the board in the near future we will just keep the fork as a working edition, and this can obviously be ignored, but after these changes, our env. worked with no consoles from the migration plugin.
Related jQuery issues should have been reverted to use native behaviour, however there might edge cases, particularly with the typeof changes, that we didn't think of, so all feedback is of course welcome.
Checklist before pull request
masterbranchnpm testlocallyFixes
For an upgrade to jQuery 3.5.1, using the migration plugin a couple of errors was thrown when running in QA env. This fork was created in anticipation of an update that would fix this issue, if this is not on the board in the near future we will just keep the fork as a working edition, and this can obviously be ignored, but after these changes, our env. worked with no consoles from the migration plugin.
Related jQuery issues should have been reverted to use native behaviour, however there might edge cases, particularly with the
typeofchanges, that we didn't think of, so all feedback is of course welcome.$.isFunction() => typeof X === ‘function’ https://api.jquery.com/jquery.isfunction/
$.isArray() => Array.isArray() https://api.jquery.com/jQuery.isArray/#jQuery-isArray-obj
$.type() => typeof X === ‘string’ https://api.jquery.com/jQuery.type/#jQuery-type-obj
$.trim(val) => val.trim() https://api.jquery.com/jQuery.trim/#entry-examples