search

xdan / periodpicker

Empty repository for paid periodpicker version
14 stars 2 forks source link

Time validation using date and time #83

Open billvsd opened 5 years ago

billvsd commented 5 years ago

When having the time and date selection, there seems to be a bug where, in multiple scenarios, the time field is highlighted in red as invalid and it won't accept the selection. For example, on the index.html demo page included with it, if you select a time, then you select a date, you cannot change the time selection after you set it once. Here is a video of the out-of-the-box behavior. I have confirmed this behavior in both the latest version of Chrome and IE.

https://youtu.be/Qn4S2HYRDlk

billvsd commented 5 years ago

After further investigation, it looks like the issue may be with the defaultEndTime. Even though norange is set to true, it appears that it is still using some value for an end time. Changing the defaultEndTime to 23:59 seems to be a work-around for the issue. I would suggest making sure that the end time validation isn't triggered when not selecting a range.