search

xdata-skylark / libskylark

Sketching-based Distributed Matrix Computations for Machine Learning
Other
98 stars 20 forks source link

kernel_container_t has a _type attribute. #48

Closed positiveblue closed 7 years ago

positiveblue commented 8 years ago

It give us information about which kenrel is. std::_type = (linear, gaussian, etc...)

haimav commented 8 years ago

Why is it needed?

positiveblue commented 8 years ago

Debugging

For example, if KernelRige is throwing some error and we want to know if it is related to the kernel that is passed. We could check it when we are creating the kernel but it's better if the container 'has all the information'. It would be easier to debug then.

haimav commented 8 years ago

Good point, but can't we use RTTI for that? That said, it might easier to work with the _type as you implemented.

positiveblue commented 7 years ago

see #43 for more information