search

xdata-skylark / libskylark

Sketching-based Distributed Matrix Computations for Machine Learning
Other
98 stars 20 forks source link

CMake -DBUILD_ML=OFF does not deactivete some CLI tools #50

Closed positiveblue closed 7 years ago

positiveblue commented 8 years ago

Running the command make after 

CC=mpicc CXX=mpicxx cmake -DBUILD_ML=OFF -DUSE_FFTW=ON -DUSE_COMBBLAS=ON -DBOOST_ROOT=/usr/local/include -DBUILD_EXAMPLES=OFF -DCMAKE_INSTALL_PREFIX=${SKYLARK_INSTALL_DIR} ${SKYLARK_SRC_DIR}

compiles three targets: capi (libskylark.so), skylark_linear, skylark_svd.

I think this is not how it should work because -DBUILD_ML=OFF. Is this the normal behavior or we have to change it?

positiveblue commented 8 years ago

If this is not ML we could have -DBUILD_NLA

haimav commented 8 years ago

-DBUILD_ML=OFF only turns off the building of cli under ml. The ones you mention are under nla. We should probably have also a -DBUILD_NLA.

positiveblue commented 7 years ago

Effectively, we have an -DBUILD_NLA too.

I have moved both ML and NLA applications to its own folder. I think that it is not really a "feature" and should have their own space. #52

Do you have any objection? @haimav @gidiko