search

xdd666t / getx_template

Used to generate the template code of GetX framework | Flutter GetX模板代码生成（一个有用的IDEA插件）
Apache License 2.0
295 stars 67 forks source link

Good practices #1

Closed mjablecnik closed 3 years ago

mjablecnik commented 3 years ago

Hello, this is nice work.. And for me for fan of GetX this plugin can be very usable.

But I see that you are making you comment your code or commits in nonenglish language. But some programmers which can make some contributes are from different country then you and doesn't understand your language. So it is a good practice make any comments in code in english language which is universal simple language used everywhere any programmers around the world.. ;) :)

And it is also consistent because in all your code everywhere will be used only one language which is understandable for any programmer.. ;)

xdd666t commented 3 years ago

Hello, this is nice work.. And for me for fan of GetX this plugin can be very usable.

But I see that you are making you comment your code or commits in nonenglish language. But some programmers which can make some contributes are from different country then you and doesn't understand your language. So it is a good practice make any comments in code in english language which is universal simple language used everywhere any programmers around the world.. ;) :)

And it is also consistent because in all your code everywhere will be used only one language which is understandable for any programmer.. ;)

Hi mjablecnik

Thank you for your suggestion, the notes and other information in the project have all been adjusted

hope it is of help to you :)

mjablecnik commented 3 years ago

Really? I still see somewhare some strange characters..: https://github.com/CNAD666/getx_template/blob/main/src/main/java/NewGetX.java#L62 ;)

xdd666t commented 3 years ago

Really? I still see somewhare some strange characters..: https://github.com/CNAD666/getx_template/blob/main/src/main/java/NewGetX.java#L62 ;)

Hi buddy, You are right. It is my negligence. I have corrected

mjablecnik commented 3 years ago

Thank you very much :)