fix: namespaced exceptions could not be ignored

xdebug / vscode-php-debug

PHP Debug Adapter for Visual Studio Code 🐞⛔

MIT License

768 stars 175 forks source link

fix: namespaced exceptions could not be ignored #891

Closed 8ctopus closed 1 year ago

8ctopus commented 1 year ago

Namespaced exceptions could not be ignored. I decided to remove minimatch and use a simple comparison instead, because it says You must use forward-slashes only in glob expressions.
Improve ignored exceptions example

zobo commented 1 year ago

Yes, I noticed and opened an issue for me #890. I'd still like to have wildcard matching so I'm gonna write a few more tests for it.

zobo commented 1 year ago

There is also this option: minimatch(response.exception.name, glob, { windowsPathsNoEscape: true }) but I think it only works if the code runs on windows. So I'll need to find another implementation.

8ctopus commented 1 year ago

I've just tried minimatch(response.exception.name, glob, { windowsPathsNoEscape: true }) as you suggested, unfortunately it's not working.

8ctopus commented 1 year ago

Actually, I was not properly setup, it works, at least on my OS Windows.

zobo commented 1 year ago

I need to thoroughly test this on Linux and Mac too. Will try to do this evening.

zobo commented 1 year ago

I've made a separate PR where I implemented * and ** matching. Please look at https://github.com/xdebug/vscode-php-debug/pull/892/files#diff-df0963a80e4aa05ab41c92cb55f6a3d1e0426a27d746bf5cf3c6ad5bc706e25d for all the cases and let me know if I missed something.

zobo commented 1 year ago

Closing this as solved in #890 and #892

8ctopus commented 1 year ago

Sorry, I didn't get a chance to look into it yet.