search

xdebug / vscode-php-debug

PHP Debug Adapter for Visual Studio Code 🐞⛔
MIT License
768 stars 175 forks source link

Improve registerEvaluatableExpressionProvider #902

Closed zobo closed 1 year ago

zobo commented 1 year ago

Current registerEvaluatableExpressionProvider leaves a lot to be desired. Ideally this should be moved to php-instellisense as that has a clue about what the position context is standing on.

See if there is hope to improve this, or remove it.

zobo commented 1 year ago

I have removed (#918) the implementation from PHP Debug as it has no place here. This should be implemented in a language server extension. I have implemented it in https://github.com/zobo/php-language-server/pull/58 but other LSP extension probably have their own.

I need to inspect https://github.com/phpactor/phpactor and vscode-intelephense.