Refactoring - Githubissues

xdev-software / bzst-dip-java-client

Java client library for the BZST - DIP (Bundeszentralamt für Steuern - Digitaler Posteingang)

Apache License 2.0

5 stars 2 forks source link

Refactoring #14

Open JohannesRabauer opened 5 months ago

JohannesRabauer commented 5 months ago

Some internals should get refactored:

[x] Add more JavaDoc
[ ] Make HttpClient settable by user
[x] Make ReportResellerCSVParser methods not static
[ ] Change AccessTokenHttpResponse to record
[x] Check all usages of RuntimeExceptions and replace with specific type
[ ] Make validation with XSD optional
[ ] Refactor XML factories. We should only use one and not three.

AB-xdev commented 2 months ago

Introduced PMD into the develop branch from upstream.

We should also have a look at the existing problems I had to suppress in https://github.com/xdev-software/bzst-dip-java-client/commit/f67208edbc54463dcc4ac484e19611fe9e4874f3