xdev-software / chartjs-java-model

Provides Java models for Chart.js
Apache License 2.0
11 stars 6 forks source link

Consider removing ``isDrawable`` #201

Closed AB-xdev closed 1 month ago

AB-xdev commented 3 months ago

isDrawable nowadays doesn't seem to have any effect besides creating issues here in this repo.

For example I can create all kinds of Charts with no datasets without any client side exceptions.

Examples with no datasets ![RadarChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/e95bd2c6-d8e5-4c9b-a4fd-db875c35f2a4) ![ScatterChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/3c55c086-1402-411e-af8c-7110874ebc68) ![BarChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/995b6ab7-0bdd-41ec-9bb1-dc7f9e7ed0e6) ![BubbleChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/4709637c-c818-4c0b-bc97-de308ed3c993) ![DoughnutChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/1f209163-a3e1-489b-86d2-d6a633fca258) ![LineChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/611b8685-ccb8-4a35-beac-8ff132aa0782) ![PieChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/249ff8e3-1b9a-4847-9e56-339059647285) ![PolarChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/779c7587-f52e-4c5e-ad4b-75f5ddecd10b)
Examples with a single empty dataset ![ScatterChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/f78d6e8e-f386-41ce-9220-ff30fce0bcb6) ![BarChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/b4088b95-e8a3-4bb3-b38d-c2b7d8bd74d7) ![BubbleChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/6ca2f4c0-d6fb-4510-a408-a2b5edc1de16) ![DoughnutChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/8eca9742-a8bf-43b8-b670-a215f80cac64) ![LineChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/1d1b7c7d-dc6d-4cb2-b692-e927f3e85fc2) ![PieChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/dc241a82-ae6f-4106-bf39-19fd2e7e9ae3) ![PolarChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/3639e364-0a41-4783-951e-a488b388b666) ![RadarChartBasic](https://github.com/xdev-software/chartjs-java-model/assets/45384811/eff6eeef-5f1a-4b63-9447-a4fa1d502ffc)