vb-chris
commented
1 week ago Probably related: https://github.com/xdev-software/intellij-plugin-save-actions/issues/23
Open vb-chris opened 1 week ago
vb-chris
commented
1 week ago Probably related: https://github.com/xdev-software/intellij-plugin-save-actions/issues/23
AB-xdev
commented
1 week ago Thank you for the issue.
We haven't seen this problem for a while now and it's nearly impossible to reproduce (as can be seen in #23 ). I personally saw that error maybe once in the last 2 years.
Do you have any other plugins installed or any special files/windows open inside IDEA during startup that may be related to the problem? Or anything else that may help in narrowing down the problem?
vb-chris
commented
1 week ago Thanks for your instant response! I experienced this issue since an upgrade from 2024.1 to 2024.2 a few days ago, have been using previous versions for years without it. I opened ~10 projects today, and the error occured in 2 of them right after opening the IDE. I will keep an eye on it and report anything that may help to spot the cause.
AB-xdev
commented
1 week ago So I had a look and I think the following is happening here:
DefaultKeyboardFocusManager
FileDocumentManagerImpl.saveAllDocumentsSaveActionsDocumentManagerListener.beforeAllDocumentsSavingSaveWriteCommandSaveCommittingDocumentsVetoer)
com.jetbrains.rdserver.ui.BackendMessagesService is invoked - This class is not present inside the IntelliJ source code and must have originated from a plugin
showMessageDialog checks if a cwm session is active and if this is the case allows the dialog to be controlled remotely. Otherwise it just performs a normal call to MessagesServiceImpl.→ The dialog likely can't be displayed as we are still inside a Keyboard event and the crash occurs
AB-xdev
commented
1 week ago The malfunction is likely caused by the fact that ProjectSettingsTracker#submitSettingsFilesRefresh saves all open files during project load.
It looks like this problem was introduced in IntelliJ 2020.1 and fixed in IntelliJ 2024.3 (EAP) with https://github.com/JetBrains/intellij-community/commit/765caa71175d0a67a54836cf840fae829da590d9
When opening a project with 2024.3 the beforeAllDocumentsSaving method is no longer called which effectively fixes this problem.
AB-xdev
commented
1 week ago Another problem seems to be that the IDE incorrectly detects "Save Files During Commit".
Related:
@vb-chris
Settings > Tools > Actions on Save?File > Invalidate Caches -> Tick "Clear file system..." and "Clear VCS Log...")?vb-chris
commented
1 week ago Thanks a lot for your in-depth investigation.
Do you have anything active inside Settings > Tools > Actions on Save?
Yes:
Do you commit using the IDE or are you using an external app like "GtiHub Desktop"?
I'm using the IDE only.
Is the problem gone if you invalidate the IDE cache (File > Invalidate Caches -> Tick "Clear file system..." and "Clear VCS Log...")?
Sorry, I can't tell. I avoid invalidation of the file system cache because it erases local history. I could Clear VCS Log caches and indexes if that helps analyzing the problem.
The exception seems to be without impact on the IDE, so it's no problem for me to wait for 2024.3 and see if the upstream changes fix the problem as supposed.
AB-xdev
commented
1 week ago Do you have anything active inside Settings > Tools > Actions on Save?
Yes:
That's an image of our Save Action plugin (not the IntelliJ built-in "Actions on Save"). Could you please recheck for "Actions on Save"?
Is the problem gone if you invalidate the IDE cache (File > Invalidate Caches -> Tick "Clear file system..." and "Clear VCS Log...")?
Sorry, I can't tell. I avoid invalidation of the file system cache because it erases local history. I could Clear VCS Log caches and indexes if that helps analyzing the problem.
The exception seems to be without impact on the IDE, so it's no problem for me to wait for 2024.3 and see if the upstream changes fix the problem as supposed.
I suspect that due to some reason IntellJ believes that some files are currently being committed during startup. Maybe the IDE crashed during a commit once or something like this. Clearing VCS cache only should also do the job.
AB-xdev
commented
1 week ago So before I vanish into the weekend: I also deployed a new snapshot of the plugin. This should fix the project load / startup problem. You may check it out, maybe it helps :)
vb-chris
commented
5 days ago Could you please recheck for "Actions on Save"?
Sorry, I mixed that up. All checkboxes in Actions on Save are disabled.
The error didn't occur anymore since I reported this issue. I will clear the VCS cache and keep an eye on it. When the error happens to occur again, I'll try the plugin snapshot you posted and report back.
Checklist
Affected version
1.2.3
Steps to reproduce the bug
The behavior is intermittent: it happens sometimes, sometimes not. I didn't see a pattern yet.
Expected behavior
No Exception.
Actual behavior
An exception is reported by Intellij:
Additional information