search

xdevplatform / twitter-python-ads-sdk

A Twitter supported and maintained Ads API SDK for Python.
https://twitterdev.github.io/twitter-python-ads-sdk/
MIT License
189 stars 106 forks source link

VideoConverstionCard entity class missing name property available in API #230

Closed shaun10 closed 5 years ago

shaun10 commented 5 years ago

Just wondering why name hasn't been added for video conversion cards? Should I add it in with a PR? It looks like it is available per the docs.

https://github.com/twitterdev/twitter-python-ads-sdk/blob/master/twitter_ads/creative.py#L288

https://developer.twitter.com/en/docs/ads/creatives/api-reference/video-conversation

shaun10 commented 5 years ago

Opened PR to fix with #231

smaeda-ks commented 5 years ago

The PR is merged, thanks for your help! Closing