Line item field name changes

xdevplatform / twitter-python-ads-sdk

A Twitter supported and maintained Ads API SDK for Python.

https://twitterdev.github.io/twitter-python-ads-sdk/

MIT License

189 stars 106 forks source link

Line item field name changes #277

Closed juanshishido closed 3 years ago

juanshishido commented 3 years ago

The following are based on changes in Ads API v9:

Add goal
Remove optimization and bid_unit
Rename:
- bid_type -> bid_strategy
- charge_by -> pay_by

juanshishido commented 3 years ago

@tushdante Should I update API_VERSION in this file with this diff? Or should that happen separately?

juanshishido commented 3 years ago

@tushdante Should I update API_VERSION in this file with this diff? Or should that happen separately?

Will do this in a separate diff.

ChanYiLin commented 3 years ago

Hi @juanshishido , there is an issue for this change While line item has removed 'bid_type' property, the save function in LineItem still checks the bid_type and causes property not found issue.