Update SDK to support Ruby 2.3+

xdevplatform / twitter-ruby-ads-sdk

A Twitter supported and maintained Ads API SDK for Ruby.

https://twitterdev.github.io/twitter-ruby-ads-sdk/

MIT License

67 stars 71 forks source link

Update SDK to support Ruby 2.3+ #190

Closed osowskit closed 5 years ago

osowskit commented 5 years ago

Issue Type: Improvement

Changes Included:

Ruby 2.2 and earlier have been deprecated. This PR will update Rubocop/Travis CI to support the minimum version of Ruby 2.3.

Update target Ruby version in .rubocop.yml, .gemspec, and .travis.yml to 2.3
Run rubocop --auto-correct to fix common linting/performance/style warnings
- .freeze on strings is no longer required
Disabled a handful of rubocop violations (potentially revisit these post merge)
Updated Copyright information to 2019

Check List:

[x] Includes adequate test coverage for changes made.
[ ] ~Includes new or updated documentation~.

tushdante commented 5 years ago

This is awesome! Appreciate the work @osowskit ! Two things:

I'm assuming you've run the examples in the repo, just to confirm that these changes don't break anything
Can you edit the gemspec file and add us as owners? Feel free to remove Jacob and Brandon

osowskit commented 5 years ago

I'm assuming you've run the examples in the repo, just to confirm that these changes don't break anything

Excellent suggestion. I'll take a look at these now.

smaeda-ks commented 5 years ago

@osowskit Any updates on this? I'd love to get this merged for sure!

osowskit commented 5 years ago

you've run the examples in the repo, just to confirm that these changes don't break anything

I was part way through running the examples and was slowed down by not having an account with some permissions for specific features. I don't believe I'll have time in the next week or so to work on this but could add anyone to the forked repo to help 💪 this through

smaeda-ks commented 5 years ago

example scripts test for this PR:

[x] active_entities.rb (from https://github.com/twitterdev/twitter-ruby-ads-sdk/pull/195)
[x] analytics.rb
[x] audience_intelligence.rb
[x] batch_request.rb
[x] cards_fetch.rb * need some fix
[x] manual_request.rb
[ ] metric_filtering.rb => I don't know what to do with this.
[x] poll_cards.rb
[x] promoted_tweet.rb * need some fix
[x] quick_start.rb
[x] tailored_audience.rb => deprecated content, should be updated later
[x] tweet_preview.rb => can be removed
[x] tweet_previews.rb (from https://github.com/twitterdev/twitter-ruby-ads-sdk/pull/194)

I believe this can be merged. I'll open another PR once this is merged to fix some minor bugs before we release a new version.