Closed osowskit closed 5 years ago
This is awesome! Appreciate the work @osowskit ! Two things:
I'm assuming you've run the examples in the repo, just to confirm that these changes don't break anything
Excellent suggestion. I'll take a look at these now.
@osowskit Any updates on this? I'd love to get this merged for sure!
you've run the examples in the repo, just to confirm that these changes don't break anything
I was part way through running the examples and was slowed down by not having an account with some permissions for specific features. I don't believe I'll have time in the next week or so to work on this but could add anyone to the forked repo to help 💪 this through
example scripts test for this PR:
I believe this can be merged. I'll open another PR once this is merged to fix some minor bugs before we release a new version.
Issue Type: Improvement
Changes Included:
Ruby 2.2 and earlier have been deprecated. This PR will update Rubocop/Travis CI to support the minimum version of Ruby 2.3.
.rubocop.yml
,.gemspec
, and.travis.yml
to 2.3rubocop --auto-correct
to fix common linting/performance/style warnings.freeze
on strings is no longer requiredCheck List: