search

xdevplatform / twitter-ruby-ads-sdk

A Twitter supported and maintained Ads API SDK for Ruby.
https://twitterdev.github.io/twitter-ruby-ads-sdk/
MIT License
67 stars 71 forks source link

Why target_cpa_local_micro has been removed from TwitterAds::LineItem #208

Closed bugcloud closed 5 years ago

bugcloud commented 5 years ago

Issue Type: Question

Description:

target_cpa_local_micro has been removed from TwitterAds::LineItem in https://github.com/twitterdev/twitter-ruby-ads-sdk/pull/193 . I searched the reason on Developers forum and this project issues, but I cloud not find it.

PR comment is

I sorted property by name so the diff shows extra lines but FYI I simply just added:

🤔

bugcloud commented 5 years ago

@smaeda-ks I have a question to your merged PR. I want to know the reason If you have time.

smaeda-ks commented 5 years ago

Hey @bugcloud , thanks for flagging this. Probably, just my mistake. I'll fix it soon.

bugcloud commented 5 years ago

@smaeda-ks OK, I see. Thank you for your quick response 🙏

smaeda-ks commented 5 years ago

Hey @bugcloud ,

After chatted with the team internally we confirmed that the target_cpa_local_micro field was deprecated a while ago and it shouldn't be used for any endpoint parameter nowadays. (FYI, it used to be a parameter for Website Conversions objective which was gone in 2017)

That is, we may plan to remove this field from the response field of the Line Items endpoints entirely near the future and hence we've decided not to revert the change this time.

Let me know if you have any questions or please feel free to close this issue if that makes sense to you.

bugcloud commented 5 years ago

@smaeda-ks OK, I understand. Thank your for your announcement.