xdevplatform / twitter-ruby-ads-sdk

A Twitter supported and maintained Ads API SDK for Ruby.
https://twitterdev.github.io/twitter-ruby-ads-sdk/
MIT License
67 stars 71 forks source link

Update URL param encoding to use CGI #232

Closed osowskit closed 4 years ago

osowskit commented 4 years ago

Issue Type: Bug Fix

Fixes / Relates To: #123

Relates to a Twurl Bug Fix Changes Included:

URI.encode_www_form is deprecated and doesn't properly encode URL params to OAuth 1.0a spec. Updating code to use CGI.escape to properly encode URL params Includes fixes specified in #228 because I'm lazy Check List:

Includes adequate test coverage for changes made. Includes new or updated documentation. Includes new or updated usage examples. For more information on check list items, please see the Contributors Guide.