search

xdevplatform / twitter-ruby-ads-sdk

A Twitter supported and maintained Ads API SDK for Ruby.
https://twitterdev.github.io/twitter-ruby-ads-sdk/
MIT License
67 stars 71 forks source link

Fix TwitterAds::Analytics.fetch_async_job_data for Ruby 3 #256

Closed Pimentoso closed 2 years ago

Pimentoso commented 2 years ago

The TwitterAds::Analytics.fetch_async_job_data method relies on open-uri override for the Kernel.open method to read the job data url. This is broken in Ruby 3, so I changed it to URI.open.

osowskit commented 2 years ago

Thanks for the changes. I'm going to merge this into a ruby v3 branch and test before releasing this. Let us know if you've found anything else that needs to get updated.