search

xdg-rs / dirs

a low-level library that provides config/cache/data paths, following the respective conventions on Linux, macOS and Windows
186 stars 23 forks source link

breaking change: Correct behavior of config_dir on macOS #41

Closed tesuji closed 4 years ago

tesuji commented 4 years ago

Although this PR does a breaking change for macOS target only, we have to bump major version after merging this PR.

We talked about how we might want to have a migration mechanics for users. But since dirs crate (the one we folked) did the breaking change in v3, and everybody seems to be happy with it, here we are with this PR.

Closes #21

tesuji commented 4 years ago

ping @Dylan-DPC I will merge this PR after a few days from now unless there is objective.

Dylan-DPC-zz commented 4 years ago

looks good to me :)

tesuji commented 4 years ago

@bors r=Dylan-DPC

tesuji commented 4 years ago

bors r=Dylan-DPC

bors[bot] commented 4 years ago

Build succeeded: