xdissent / ievms

Automated installation of the Microsoft IE App Compat virtual machines
http://xdissent.github.com/ievms
9.85k stars 495 forks source link

IEVMS_VERSIONS variable does not apply #259

Open frediy opened 9 years ago

frediy commented 9 years ago

I tried running the command curl -s https://raw.githubusercontent.com/xdissent/ievms/master/ievms.sh | env IEVMS_VERSIONS="8" bash

It starts downloading IE6 Downloading OVA ZIP from http://virtualization.modern.ie/vhd/IEKitV1_Final/VirtualBox/OSX/IE6_WinXP.zip

When trying to only install 7 or 8, it starts downloading IE6. When trying to install 9, 10 or 11, it starts downloading IE9. This does not seem like expected behavior.

I'm on Mac OSX Yosemite 10.10.3, iTerm2 Build 2.9.20150523-nightly

miquelfire commented 9 years ago

Actually, the nature of this script is to download as little as possible, and the way it gets around that is to download the lowest possible version (in the case of 6, 7 and 8, it downloads 6) and have the VM download the installer for the correct version of the IE afterwards, so the end result, you download ONE VM image, and get multiple versions of IE from that one.

frediy commented 9 years ago

That makes sense. I wonder if it's possible to indicate this a bit more clearly in the output. Maybe something like "Building IE8 VM for VM image IE6 - WinXP".

miquelfire commented 9 years ago

See this: https://github.com/xdissent/ievms#bandwidth-requirements

But yes, something in the script would be nice considering how deep in the readme that is.

frediy commented 9 years ago

Ah I see, kudos for documenting it :+1: I think outputting something makes sense. If REUSE_XP=yes, it could say "REUSE_XP=yes: Installing IE versions {versions} on {image name}". Same for REUSE_WIN7. My bash script isn't amazing, but I could give it a shot this weekend if you like that idea.

xdissent commented 9 years ago

So you just didn't trust the Building IE 8 message that's logged at the very beginning? =)

danwdart commented 8 years ago

Doesn't make much sense though if I wanted "11 EDGE" that it would try to download IE9_Win7 though, does it? The smallest possible download would be to get only Win10 surely?