search

xdissent / ievms

Automated installation of the Microsoft IE App Compat virtual machines
http://xdissent.github.com/ievms
9.86k stars 497 forks source link

Virtualbox extension pack fails MD5 checksum #301

Closed csi-lk closed 8 years ago

csi-lk commented 8 years ago

Don't know if the md5 for ievms is wrong or the file from virtualbox.org has been corrupted

Full stacktrace

$ curl -s https://raw.githubusercontent.com/xdissent/ievms/master/ievms.sh | bash
Checking for VirtualBox
Checking for Oracle VM VirtualBox Extension Pack
Virtualbox version 5.0.16 found.
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   279  100   279    0     0    235      0  0:00:01  0:00:01 --:--:--   235
100   280  100   280    0     0    170      0  0:00:01  0:00:01 --:--:--   170
100   493  100   493    0     0    263      0  0:00:01  0:00:01 --:--:--     0
Found Oracle VM VirtualBox Extension Pack at Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack - skipping download
MD5 check failed for Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack (wanted , got 41f1d66e0be1c183917c95efed89db56)
Check failed - redownloading Oracle VM VirtualBox Extension Pack
Downloading Oracle VM VirtualBox Extension Pack from http://download.virtualbox.org/virtualbox/5.0.16/Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack to Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack (attempt 1 of 3)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 16.1M  100 16.1M    0     0  5435k      0  0:00:03  0:00:03 --:--:-- 5436k
MD5 check failed for Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack (wanted , got 41f1d66e0be1c183917c95efed89db56)
Redownloading Oracle VM VirtualBox Extension Pack
Found Oracle VM VirtualBox Extension Pack at Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack - skipping download
MD5 check failed for Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack (wanted , got 41f1d66e0be1c183917c95efed89db56)
Check failed - redownloading Oracle VM VirtualBox Extension Pack
Downloading Oracle VM VirtualBox Extension Pack from http://download.virtualbox.org/virtualbox/5.0.16/Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack to Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack (attempt 2 of 3)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 16.1M  100 16.1M    0     0  4034k      0  0:00:04  0:00:04 --:--:-- 4035k
MD5 check failed for Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack (wanted , got 41f1d66e0be1c183917c95efed89db56)
Redownloading Oracle VM VirtualBox Extension Pack
Found Oracle VM VirtualBox Extension Pack at Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack - skipping download
MD5 check failed for Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack (wanted , got 41f1d66e0be1c183917c95efed89db56)
Check failed - redownloading Oracle VM VirtualBox Extension Pack
Downloading Oracle VM VirtualBox Extension Pack from http://download.virtualbox.org/virtualbox/5.0.16/Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack to Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack (attempt 3 of 3)
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 16.1M  100 16.1M    0     0  7591k      0  0:00:02  0:00:02 --:--:-- 7593k
MD5 check failed for Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack (wanted , got 41f1d66e0be1c183917c95efed89db56)
Failed to download http://download.virtualbox.org/virtualbox/5.0.16/Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack to /Users/csilk/.ievms/Oracle_VM_VirtualBox_Extension_Pack-5.0.16.vbox-extpack (attempt 3 of 3)
csi-lk commented 8 years ago

Tried again today and is working, must have been something weird on the virtualbox.org site, closing ticket

jamesseanwright commented 8 years ago

Getting the same issue today, so I cloned the script and skipped the check like a rebel! If this becomes a persistent problem, would you be comfortable with adding an environment variable to skip the MD5 check? Cheers!

mvaneijgen commented 8 years ago

Having the same issue, and have no idea how to modify the check. Does someone care to explain?

jamesseanwright commented 8 years ago

The method you want is check_md5 on line 43 of the the ievms.sh script; you need to remove the return 1 in the failure case:

check_md5() {
    local md5

    case $kernel in
        Darwin) md5=`md5 "${1}" | rev | cut -c-32 | rev` ;;
        Linux) md5=`md5sum "${1}" | cut -c-32` ;;
    esac

    if [ "${md5}" != "${2}" ]
    then
        log "MD5 check failed for ${1} (wanted ${2}, got ${md5})"
    fi

    log "MD5 check succeeded for ${1}"
}

The check will still fail, but it will at least permit the installation to continue.

@xdissent - I'm more than happy to do a pull request to make the check skippable by means of an environment variable, since this is a recurring problem. What are your thoughts on such functionality?

corysimmons commented 8 years ago

Experiencing this as well. It'd be nice to have a skip flag. In the meantime, here is James' fix:

curl -s https://gist.githubusercontent.com/corysimmons/62cce98d9931033bfc1bba27ce883d04/raw/d7748eb406eb07f6e7cdf3f0166399722c0b1104/ievms.sh | bash