Request: Better syntax highlighting for Clojure

[Jarzka]

Hello

First of all, nice port of the original theme for IDEA. I only wish it had better support for Clojure language. Now function calls are highlighted as keywords and keywords are not highlighted at all, which feels incorrect.

I fine-tuned the theme a bit for Clojure and I believe others might like it too. However, I have no idea how to export the modifications out of IDEA to be PR friendly. Can you help with this?

[xdrop]

Hello, thanks for your comment. Unfortunately I don't know Closure so it would be hard for me to create a version for it, but a PR would be most welcome. 🙂

For creating the PR you have two options:

• Edit src/main/resources/colors/NightOwl.xml manually in a text editor by searching for the keyword you want highlighted differently and altering the color code there. The problem with that is that some keys might be missing because they haven't been highlighted before

• Second option

  1. Clone and open this project in IntelliJ. Go to src/main/resources/colors/NightOwl.xml
  2. Go to your IntelliJ Preferences Directory under colors and find your modified _@user_Night Owl.icls
  3. Copy and paste over the contents of the modified over src/main/resources/colors/NightOwl.xml
  4. Go to Code > Reformat code to ensure they are in consistent styling (this will cause way of a bigger diff than it should if not done)
  5. Now go to the Commit screen on IntelliJ and ensure only the lines that make sense are ticked to be part of the commit (partial commit)
  6. Commit and push your PR, if there any issues we can fix them before merging

Again if at any point you have any issues feel free to post them here and I'd be happy to help 👍

[Jarzka]

I'll try these options soon. Meanwhile, here is a screenshot of the theme where keywords are highlighted the way I personally like. We could use something like this:

https://imgur.com/a/wfns5YW

[xdrop]

@Jarzka Great, thanks!

[Jarzka]

It seems that "soon" took me longer than a few months. :D

Anyway, I took a look at my modifications. There are some, compared to your original file, and I'm unable to understand which modifications are related to Clojure. "Clojure" is not even mentioned in the file.