xdspacelab / openvslam

OpenVSLAM: A Versatile Visual SLAM Framework
https://openvslam.readthedocs.io/
2.97k stars 869 forks source link

Invalid epipole check in match_for_triangulation #526

Open adelpit opened 3 years ago

adelpit commented 3 years ago

The epipole check is being performed here even if reproject_to_bearing returns false and epiplane_in_keyfrm_2 is invalid. This can happen for, for example, perspective cameras when the epipole is not visible. The resulting value of epiplane_in_keyfrm_2 is not normalized which can cause a significant number of potential matches to fail this check.

The fix is in this PR: https://github.com/xdspacelab/openvslam/pull/525