A system for running games using various 2d6-based role-playing games, specifically with the Cepheus Engine Core Rules and similar systems. <br/>This Product is derived from the Traveller System Reference Document and other Open Gaming Content made available by the Open Gaming License, and does not contain closed content from products published by either Mongoose Publishing or Far Future Enterprises. This Product is not affiliated with either Mongoose Publishing or Far Future Enterprises, and it makes no claim to or challenge to any trademarks held by either entity. The use of the Traveller System Reference Document does not convey the endorsement of this Product by either Mongoose Publishing or Far Future Enterprises as a product of either of their product lines.<br/>Cepheus Engine and Samardan Press™ are the trademarks of Jason "Flynn" Kemp; I am not affiliated with Jason "Flynn" Kemp or Samardan Press™.<br/> See the files OpenGameLicense.md and LICENSE for license details..<br/>
Other
39
stars
25
forks
source link
feat: Remove AE apply override and remove some hooks optional statuses linking #1579
[x] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
refactor
What is the current behavior? (You can also link to an open issue here)
TwosixActor has custom AE override to allow for AE on derived data
CUSTOM calculation mode for AE uses Hook
Item AE disabled through actor updates
Changing item type now causes data model error
Can't link Target DM to actor statuses
What is the new behavior (if this is a feature change)?
Remove override and have a special application for allowed derived values and Custom AE
Custom calc mode uses extended AE class
Item AE now suppressed with AE getter
Refactor change item type to create and delete a new item and clean data on change
Refactor from Hook onUpdate for actors and items to their respective _onUpdate overrides
Optional link string added to Target DM modifiers
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
?? Custom AE calc hook is now bypassed
Other information:
Wiki on Target DM now includes a small section on the optional status linking
github-actions[bot]
commented
5 months ago
Please check if the PR fulfills these requirements
[x] We use semantic versioning (https://github.com/semantic-release/semantic-release to be specific), so follow https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines
[x] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) refactor
What is the current behavior? (You can also link to an open issue here) TwosixActor has custom AE override to allow for AE on derived data CUSTOM calculation mode for AE uses Hook Item AE disabled through actor updates Changing item type now causes data model error Can't link Target DM to actor statuses
What is the new behavior (if this is a feature change)? Remove override and have a special application for allowed derived values and Custom AE Custom calc mode uses extended AE class Item AE now suppressed with AE getter Refactor change item type to create and delete a new item and clean data on change Refactor from Hook onUpdate for actors and items to their respective _onUpdate overrides Optional link string added to Target DM modifiers
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) ?? Custom AE calc hook is now bypassed
Other information: Wiki on Target DM now includes a small section on the optional status linking