This also makes it more efficient. It was downloading every single macro in the compendium, then finding the selected one to copy and execute.
getDocuments can search by name, it's an indexed field, so use that to only download the selected macro. And only make a copy of the macro if it can't be executed. The default permissions will allow it to be executed without a copy.
This doesn't have a migration script to fix existing wrapper macros that have been copied out of the compendium, i.e. macros people have already placed onto their hotbar.
Please check if the PR fulfills these requirements
This also makes it more efficient. It was downloading every single macro in the compendium, then finding the selected one to copy and execute.
getDocuments can search by name, it's an indexed field, so use that to only download the selected macro. And only make a copy of the macro if it can't be executed. The default permissions will allow it to be executed without a copy.
This doesn't have a migration script to fix existing wrapper macros that have been copied out of the compendium, i.e. macros people have already placed onto their hotbar.
Please check if the PR fulfills these requirements
[ ] We use semantic versioning (https://github.com/semantic-release/semantic-release to be specific), so follow https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines.)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Bug Fix
What is the current behavior? (You can also link to an open issue here) Doesn't work on V12.
What is the new behavior (if this is a feature change)? Works on V12.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: