xdy / xdy-pf2e-workbench

Random assortment of possibly useful doodads, thingumabobs and whatchamacallits for the foundry vtt pf2e system.
Other
22 stars 37 forks source link

Fix the macro wrapper for V12 #1356

Closed xyzzy42 closed 4 months ago

xyzzy42 commented 4 months ago

This also makes it more efficient. It was downloading every single macro in the compendium, then finding the selected one to copy and execute.

getDocuments can search by name, it's an indexed field, so use that to only download the selected macro. And only make a copy of the macro if it can't be executed. The default permissions will allow it to be executed without a copy.

This doesn't have a migration script to fix existing wrapper macros that have been copied out of the compendium, i.e. macros people have already placed onto their hotbar.

mergify[bot] commented 4 months ago

This pull request is now in conflicts. Could you fix it? 🙏

github-actions[bot] commented 4 months ago

:tada: This PR is included in version 6.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: