Every use of the skill name, except one, turned it into a lowercase skill slug. And the one that didn't was a bug!
Just make it lowercase in the action data to start with.
The bug was in the getSkills() call, but it didn't matter since none of the actions that use it have MAP. I.e., it would try to look up actor.skills.Crafting and fail for the repair action, but the value would never be used since only the MAP variant code used it and repair has no MAP. The same for Aid and Raise a Shield, the only other call sites.
Please check if the PR fulfills these requirements
Every use of the skill name, except one, turned it into a lowercase skill slug. And the one that didn't was a bug!
Just make it lowercase in the action data to start with.
The bug was in the getSkills() call, but it didn't matter since none of the actions that use it have MAP. I.e., it would try to look up
actor.skills.Crafting
and fail for the repair action, but the value would never be used since only the MAP variant code used it and repair has no MAP. The same for Aid and Raise a Shield, the only other call sites.Please check if the PR fulfills these requirements
[x] We use semantic versioning (https://github.com/semantic-release/semantic-release to be specific), so follow https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines.)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: