The way it did the background color and the choice of selectors made it problematic to theme BAM.
Instead of adding a style background directly to the buttons, give them data properies with the skill rank. Then use that in the css to select colors. Which now use var names from the pf2e css that match the abilities tab on the char sheet, instead of copying the color hex codes.
With the foreground and background color in the same place, it's possible to override neither or both. But overriding one, so that a light theme foreground is combined with a dark theme background, shouldn't happen.
Please check if the PR fulfills these requirements
The way it did the background color and the choice of selectors made it problematic to theme BAM.
Instead of adding a style background directly to the buttons, give them data properies with the skill rank. Then use that in the css to select colors. Which now use var names from the pf2e css that match the abilities tab on the char sheet, instead of copying the color hex codes.
With the foreground and background color in the same place, it's possible to override neither or both. But overriding one, so that a light theme foreground is combined with a dark theme background, shouldn't happen.
Please check if the PR fulfills these requirements
[ ] We use semantic versioning (https://github.com/semantic-release/semantic-release to be specific), so follow https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines.)
[ ] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: