xdy / xdy-pf2e-workbench

Random assortment of possibly useful doodads, thingumabobs and whatchamacallits for the foundry vtt pf2e system.
Other
22 stars 37 forks source link

fix: Make BAM work with Dorako UI #1417

Closed xyzzy42 closed 1 month ago

xyzzy42 commented 1 month ago

The way it did the background color and the choice of selectors made it problematic to theme BAM.

Instead of adding a style background directly to the buttons, give them data properies with the skill rank. Then use that in the css to select colors. Which now use var names from the pf2e css that match the abilities tab on the char sheet, instead of copying the color hex codes.

With the foreground and background color in the same place, it's possible to override neither or both. But overriding one, so that a light theme foreground is combined with a dark theme background, shouldn't happen.

github-actions[bot] commented 1 month ago

:tada: This issue has been resolved in version 6.7.13 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: