search

xdy / xdy-pf2e-workbench

Random assortment of possibly useful doodads, thingumabobs and whatchamacallits for the foundry vtt pf2e system.
Other
22 stars 37 forks source link

Make animations appear off-target setting does not work #245

Closed MrVauxs closed 2 years ago

MrVauxs commented 2 years ago

As the title implies, despite turning the setting off, miss and even critical hit animations consistently appear off-target. image

MrVauxs commented 2 years ago

chrome_im3Sb6jt3L chrome_FBh92Bd89I

image

xdy commented 2 years ago

That is strange. As you can see it works for me:

https://user-images.githubusercontent.com/246024/167290782-4afc9d7c-65c6-46d5-99e5-d5a1369bdd34.mp4

image

Could you try with only the modules I used? (I.e. The Workbhench, AA and it's dependencies.)

xdy commented 2 years ago

I also tried with the current release (the above was on a developer build), which also worked.

MrVauxs commented 2 years ago

That is strange. As you can see it works for me:

Video.mp4 image

Could you try with only the modules I used? (I.e. The Workbhench, AA and it's dependencies.)

Still appears with the modules you posted. Only difference is that I have an up to date JB2A collection. image

xdy commented 2 years ago

I updated to the latest JB2A but that made no difference. For me it works in both Chrome and Firefox, as player and as gm. Does it work if you make a new test world?

MrVauxs commented 2 years ago

It does.

I can give access to the world, if you want. Would rather do it over on Discord though. MrVauxs#8622

MrVauxs commented 2 years ago

The issue is with play Animations on Hits and Misses setting in Automated Animations. For some reason the animations from the workbench and AA are coupled together.

image

MrVauxs commented 2 years ago

Any progress on this?

xdy commented 2 years ago

As support for sounds and animation on hits and misses is deprecated and will soon be removed (replaced by better functionality in https://github.com/MrVauxs/pf2e-jb2a-macros) I'm closing this issue.