xdy / xdy-pf2e-workbench

Random assortment of possibly useful doodads, thingumabobs and whatchamacallits for the foundry vtt pf2e system.
Other
22 stars 37 forks source link

Bad scaling for Vampiric Mist? #427

Open xdy opened 2 years ago

xdy commented 2 years ago

From https://discord.com/channels/880968862240239708/880969174661353484/1020519016403587153 if you use the level scaling from workbench on a Vampiric Mist to take it from level 3 to 4, it raises its will save from +9 to +14 and lowers the damage on its strike from 2d6 to 2d4. Any idea why it would do such a thing?

xdy commented 2 years ago

I won't do this right now, but this change would handle the Vampiric Mist (does a bit too little damage for it's level, has no damage bonus, scaled a single level) a bit better. Might cause other problems.

Index: src/module/feature/cr-scaler/NPCScalerUtil.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/module/feature/cr-scaler/NPCScalerUtil.ts b/src/module/feature/cr-scaler/NPCScalerUtil.ts
--- a/src/module/feature/cr-scaler/NPCScalerUtil.ts (revision 3caccd108db22b540b8f00ca13f6cc59dce0a400)
+++ b/src/module/feature/cr-scaler/NPCScalerUtil.ts (date 1665854980315)
@@ -148,7 +148,7 @@
 export function constructRelativeDamage(oldDmg: IDicePool, stdDmg: IDicePool, newDmg: IDicePool): IDicePool {
     const count = newDmg.diceCount;
     const size = newDmg.diceSize;
-    const bonus = newDmg.bonus + oldDmg.bonus - stdDmg.bonus;
+    const bonus = newDmg.bonus + Math.round(oldDmg.average - stdDmg.average);

     return parseDamage(
         constructFormula({