xeals / signal-back

Decrypt Signal encrypted backups outside the app
Apache License 2.0
704 stars 67 forks source link

CSV and raw format missing image captions #55

Open EvilRenegade opened 5 years ago

EvilRenegade commented 5 years ago

It is a known fact that the CSV export does not (by its very nature) contain the images of a conversation.

However, looking at the messages in detail, I realized that for messages that contain an image and text, the text is missing as well. The message just plain doesn't exist in the output. That obviously leads to missing parts of the conversation.

I assume the algorithm generating the filenames in extract mode is deterministic. Would it be possible to include all messages with media in CSV mode, but replacing the actual image with the text [attachment:$filename], so that one could check the extracted attachments for that file name?

Either way, at least the text of such a message should be exported, regardless of attachment handling.

Edit: Affects raw export as well. Can't test XML because of #16.