xeals / signal-back

Decrypt Signal encrypted backups outside the app
Apache License 2.0
704 stars 67 forks source link

Panic: Undefined SMS type: 24 #6

Closed BlakeBLuther closed 6 years ago

BlakeBLuther commented 6 years ago

As the title says, getting a panic on SMS type 24 when trying to format.

According to my novice interpretation of Signal's code repo, it looks like it's choking on the SENT_FAILED type:

protected static final long BASE_INBOX_TYPE                    = 20;
protected static final long BASE_OUTBOX_TYPE                   = 21;
protected static final long BASE_SENDING_TYPE                  = 22;
protected static final long BASE_SENT_TYPE                     = 23;
protected static final long BASE_SENT_FAILED_TYPE              = 24;
protected static final long BASE_PENDING_SECURE_SMS_FALLBACK   = 25;

I'd provide more info about the specific message, if you can let me know how. I'm unsure how to dive into the backup itself.

xeals commented 6 years ago

Thanks for reporting. Looks like I forgot to hook up Signal's insecure protocols.