search

xebd / accel-ppp

High performance PPTP/L2TP/PPPoE/IPoE server for Linux
GNU General Public License v2.0
296 stars 108 forks source link

Add missing dhcp end option on dhcp notify packet #170

Closed cygnusb closed 2 years ago

cygnusb commented 2 years ago

The DHCP Notify Packet send out for the load balancing mechanism (weight) is lacking a DHCP End Option (255). For accel-ppp this is not an issue, since the only consumer of this packet should be other accel-ppp Hosts.

Our Ruckus ICX Switches try to parse these packets with activated DHCP Snooping function resulting in some critical errors on the Switch CLI:

DHCP Option82: WARNING: No END OPTION found before bounds.

So this looks really bad and fixing is easy by adding the DHCP Option 255 end marker.

cygnusb commented 2 years ago

Moved to accel-ppp/accel-ppp repo