search

xebd / accel-ppp

High performance PPTP/L2TP/PPPoE/IPoE server for Linux
GNU General Public License v2.0
296 stars 109 forks source link

Adding blank service answer, adding back service to PADO and fix for 4.10 #9

Closed nuclearcat closed 6 years ago

nuclearcat commented 7 years ago

1)Some PPPoE answer only blank service in PADI and predefined in config service names. 2)PADO should be RFC2516 compliant. Quoting "The PADO packet MUST contain one AC-Name TAG containing the Access Concentrator's name, a Service-Name TAG identical to the one in the PADI, and any number of other Service-Name TAGs indicating other services that the Access Concentrator offers.", so we add in answer(PADO) service tag from PADI. 3)Fix for kernel 4.10, they broke userspace API, so might be better to use constant. Reference: https://patchwork.ozlabs.org/patch/734681/

nuclearcat commented 7 years ago

Please do not merge it yet, i will test this at least on 4.10