search

xebia-functional / macroid

A modular functional UI language for Android
527 stars 37 forks source link

= all: migrate macros to macro-compat #78

Closed joprice closed 8 years ago

joprice commented 8 years ago

Added scalac flags that revealed many warnings. Migrated macros to macro-compat to deal with many of them. Configured tests using roboelectric and added simple test for Bundles.

stanch commented 8 years ago

Looks like robotest is not published for 2.10. Actually at some point we should consider dropping 2.10 support, since it will reach end of life soon... This would simplify quite a few things with macros as well.

stanch commented 8 years ago

Awesome work. This paves the way to better code quality and proper tests :)

joprice commented 8 years ago

Ok I have the other fixes ready, but it's still going to fail on 2.10. Can this be the version we drop 2.10 support?

stanch commented 8 years ago

I’m not using it, so to me it doesn’t really matter :) But I think the best approach is to ask @47deg and on the mailing list / gitter.

stanch commented 8 years ago

Another simple approach is to ask the robotest people if they could issue a 2.10 release.

joprice commented 8 years ago

I was hoping you wouldn't say that.

I just checked their code out. It has crossScalaVersions configured. Just ran the +test, and both passed against 2.10 and 2.11, so looks like it won't be an issue to publish it. I'll create an issue.

stanch commented 8 years ago

FWIW there is a new version of macro-compat :) https://groups.google.com/forum/?fromgroups#!topic/scala-user/Ypnq_iVBICg

joprice commented 8 years ago

Updated to new macro-compat version and rebuild for 2.10 passed once robotest was published.

stanch commented 8 years ago

Merged, thanks!