search

xebia-functional / scala-days-ios

Official iOS app for Scala Days
http://www.scaladays.org
25 stars 8 forks source link

SDIOS-10 / Location VC #13

Closed jdesiloniz closed 9 years ago

jdesiloniz commented 9 years ago

This PR contains the implementation of the map logic for our Location VC. Also some modifications to the model and parser to handle two new fields in the API for venue locations coordinates.

Please review @anamariamv @raulraja @rafaparadela ... Thanks!! :)

raulraja commented 9 years ago

LGTM! once all comments are addressed.

jdesiloniz commented 9 years ago

All the comments are addressed in the latest pushes, if you find the biggest change right (findCornerCoordinatesInListOfAnnotations function in SDMapView-ZoomOut extension) I'll be able to merge :) Thanks @raulraja

jdesiloniz commented 9 years ago

Switched to the mutable approach of doing the zooming in the map, as Swift won't guarantee tail call optimization, while adding information about it in the code. Merging!