search

xebia / VisualReview

VisualReview, a human-friendly tool for testing and reviewing visual regressions.
https://github.com/xebia/VisualReview#see-it-in-action
Apache License 2.0
275 stars 24 forks source link

Breadcrumb parent links #38

Closed RRMoelker closed 9 years ago

RRMoelker commented 9 years ago

Made an change to the breadcrumbs directive which will make it reusable when the list view titles also become breadcrumbs. Each link now points to the parent list view. So when looking at a suite, the suite breadcrumb link will go back to the suite list view. I think this is expected behavior.

@skwakman agreed?

RRMoelker commented 9 years ago

Or as an alternative, I think it is best to make the logo go to the home page and making the last item a none link.

To illustrate what I mean, see the image below. The leading '/' in the breadcrumb could be removed and the icon in the left could be a link to the home page. The last link in the breadcrumb is then no longer a link (as it points to the page you are on).

screen shot 2015-06-21 at 19 30 04

RRMoelker commented 9 years ago

The other breadcrumb PR (#43) is a better change probably. This can be closed if the other one is accepted.

RRMoelker commented 9 years ago

Other PR #43 is merged. Cancelling this PR.