search

xebia / VisualReview

VisualReview, a human-friendly tool for testing and reviewing visual regressions.
https://github.com/xebia/VisualReview#see-it-in-action
Apache License 2.0
275 stars 24 forks source link

automatically create screenshots dir if missing #59

Closed dmarjenburgh closed 8 years ago

dmarjenburgh commented 9 years ago

This change to init-screenshots-dir! will attempt to create the directory if it doesn't exist yet.

There is also a better checking for access rights to the dir

skwakman commented 9 years ago

Nice addition! It misses some unit tests though. Could you provide them?

dmarjenburgh commented 9 years ago

It's code that interacts heavily with the file system. Do you want the unit tests to create and delete temporary dirs?