search

xebia / VisualReview

VisualReview, a human-friendly tool for testing and reviewing visual regressions.
https://github.com/xebia/VisualReview#see-it-in-action
Apache License 2.0
275 stars 24 forks source link

Optional compareSettings implemented #71

Closed FinKingma closed 8 years ago

FinKingma commented 8 years ago

I added an optional compareSettings json object to the post request of sending screenshots. Right now the settings only allow for a precision factor, but next week I will focus on anti aliasing as well.

skwakman commented 8 years ago

Hi @FinKingma , thanks for the addition! Sorry that I couldn't get to it earlier. It seems that previousy merged PR's now have created a conflict with your code. Could you fix that?

skwakman commented 8 years ago

This code begs for some tests. Perhaps you could add a test to com.xebia.visualreview.itest.analysis-test?