xebia / Xebium

Xebium provides Selenium (webdriver) bindings for FitNesse, with Selenium-IDE support
http://xebia.github.com/Xebium/
Apache License 2.0
76 stars 62 forks source link

Typo in: selenium driver fixture; load firefox from profile #124

Open wvanmourik opened 10 years ago

wvanmourik commented 10 years ago

At the moment, the code is: public void loadFirefoxProfileFromDirectory(String directory) { defaultWebDriverSupplier.setCustomProfilePreferencesFile(new File(directory)); }

It should be: public void loadFirefoxProfileFromDirectory(String directory) { defaultWebDriverSupplier.setProfileDirectory(new File(directory)); }

I am guessing this typo is an copy/paste error from function: public void loadCustomBrowserPreferencesFromFile(String filename) { defaultWebDriverSupplier.setCustomProfilePreferencesFile(new File(filename)); }

jguglielmi commented 10 years ago

Similar to https://github.com/xebia/Xebium/issues/106 ?

raboof commented 10 years ago

That indeed looks like a clear mistake. Should be fixed, but as I don't use this functionality, could you test whether this indeed now works?

wvanmourik commented 10 years ago

Hi Jaison,

Almost, but not really. It seems you want a different functionality, while I just wanted the existing functionality to work. The issue is basically solved seeing the comment from raboof.

The file not found errors you got before, were because of this bug. I had those too and that is how I found this typo. Likely you can use the now fixed code and use multiple Firefox profiles by passing a directory.

Example: |load firefox profile from directory| FitnesseRoot\files\BrowserProfiles\Firefox\myprofilename|

jguglielmi commented 10 years ago

Gotcha.

jguglielmi commented 10 years ago

I was just using the setProfileDirectory method directly with the String implementation when I declared my default web driver supplier as a variable. Where as you described it was then passed into the File instance of the method which called setProfileDirectory. Thanks for @mourikwa! This should close #106 as well. I'll go ahead and tidy up...