search

xebialabs-community / puppet-xldeploy

Puppet module for managing XL Deploy
5 stars 10 forks source link

Duplicate declaration: Group[xldeploy] #115

Closed ltutar closed 8 years ago

ltutar commented 8 years ago

When I have the two classes in my node definition xldeploy::client xldeploy::server and I apply the file change of https://github.com/xebialabs/puppet-xldeploy/pull/114, I get the following error:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Group[xldeploy] is already declared in file /etc/puppetlabs/code/environments/production/modules/xldeploy/manifests/client/user.pp:29; cannot redeclare at /etc/puppetlabs/code/environments/production/modules/xldeploy/manifests/shared_prereq.pp:33 at /etc/puppetlabs/code/environments/production/modules/xldeploy/manifests/shared_prereq.pp:33:3 on node xxragent.home
superseb commented 8 years ago

Both group resources should be rewritten to ensure_resource function to fix is. Long term should be to check shared_prereq if that is sufficient.