search

xebialabs-community / xld-openshift-plugin

Plugin to deploy war files on jboss gears in open shift and support for OpenShift v3 on Kubernetes
2 stars 6 forks source link

Support Dockerfile as deployable #10

Closed jdewinne closed 7 years ago

jdewinne commented 7 years ago

Allow a dockerfile to be uploaded and used as deployable.

vpartington commented 7 years ago

A Dockerfile? Are you sure? Wouldn't you rather have a Docker image as a deployable?

Rebuilding the Docker image on every deploy doesn't seem the most efficient or repeatable process.

Or is this a OpenShift thing?

MarkRx commented 7 years ago

That does seem strange. I would think you would want to use a docker image instead.

jdewinne commented 7 years ago

Why would this be so strange? This is about also letting OpenShift do the build part. Dockerfile source

vpartington commented 7 years ago

Aha, so this is an OpenShift thing. :-) OK.

alephnot0 commented 7 years ago

Using a Dockerfile is almost equivalent to using a docker image as a Dockerfile defines the image. I say almost as there is a possibility that the image could have changed between deployments so you would have to be careful. It is faster than using a docker image as the Dockerfile might be 2KB rather than a 1GB image.

MarkRx commented 7 years ago

Ah the build mechanism. I thought you were referring to doing pushes to the internal openshift docker registry.

jdewinne commented 7 years ago

See v6.5.0