xebialabs-community / xld-openshift-plugin

Plugin to deploy war files on jboss gears in open shift and support for OpenShift v3 on Kubernetes
2 stars 6 forks source link

oc modify VS oc destroy/create during modify steps in XL Deploy #14

Open px-djozis opened 7 years ago

px-djozis commented 7 years ago

Currently when a MODIFY step in XLD occurs, an oc destroy and create is performed. This causes downtime when a service is modified to point from one deployment configuration to another, or causes deployment configuration modifications not to occur in a rolling fashion, etc.

Could this plugin be upgraded so that during a modify XLD step, oc modify commands are used by calculating the diff between the previously deployed json and the currently deploying json and applying it to the result of oc get? This is because oc get returns additional fields that cannot be lost.

We have a particular interest in this logic and ideally would like to be able to take a look at it on a branch before it reaches master, if that's ok.

jdewinne commented 7 years ago

Instead of using oc modify, could it be possible to use the blue green feature? This should be available since v7.1.0

px-djozis commented 7 years ago

@jdewinne - I wasn't able to find any documentation on the blue green feature. Where is it located?

px-djozis commented 7 years ago

I saw the blue/green video linked on the main GitHub page for this repository, but it shows switching at the route level. Is the XLD blue/green feature implemented at the route level or service level? If we deploy components separately within the same OpenShift project which communicate via the service mechanism, how will the XLD blue/green feature best support that use case?