search

xelaj / mtproto

🦋 Full-native go implementation of Telegram API
MIT License
1.23k stars 133 forks source link

v1.0.1 (bugfix) Bump github.com/xelaj/go-dry to fix goroutine leak #95

Closed paskal closed 3 years ago

paskal commented 3 years ago

Hey @quenbyako, would you be so kind as to make a change like one in this PR on top of v1.0.0 and release v1.0.1 or v1.0.0-1 with just this change and nothing else? The current master seems to be in a semi-broken state (particularly panics I can't catch scare me), so I think it's reasonable to ask for clean v1.0.1, which wouldn't break anything that is not yet broken in v1.0.0.

Thanks in advance!

quenbyako commented 3 years ago

@paskal could you please resolve conflicts in gomod files? not sure which version is which for your pr...

Also, i planning to release v1.1.0 with fixes of seqno and more improvements like builtin methods for uploading files etc. So, i'll certainly merge these changes (including your examples and more other features) so, yeah, no worries, releases will be stable always (master will be stable most of time, lol 😂)

paskal commented 3 years ago

@quenbyako sorry for not being clear, this PR is not intended to be merged to master. What I propose you do:

  1. Checkout the code and then checkout v1.0.0
  2. Create a branch v1.0.1-leak-bugfix or something like that
  3. Apply changes from this PR, e.g. go get github.com/xelaj/go-dry@21c7782 and replace dry.PathIsWirtable with dry.PathIsWritable in two places
  4. Commit them and tag the resulting commit as v1.0.1
  5. Forget about that branch for the time being

That way I'll get the same library I work with now and which behaviour I know, but with the leaking goroutines problem resolved. And for the main branch I'll prepare a separate PR with a bump.

paskal commented 3 years ago

@quenbyako would you be so kind as to release v1.0.1 with just that fix and nothing else on top of v1.0.0?