Mort/bug10220

[mcr]

create the pull request so that mcr can comment

[mohicks]

On Fri, 28 Aug 2020 at 15:41, Michael Richardson notifications@github.com wrote:

@mcr commented on this pull request.

Do we need a new unit test where we forcibly rekey the parent SA and then rekey the child? lp66 replaces the parent, I'd have to go through the others to be sure what they do.

I'll address this comment here because I don't see it on the Pull Request / Review.

I think we should fork this as a separate bug/task. It would give me a chance to look through the OSW unit tests and see what's actually there... I think it does make sense to add this as a unit test if there isn't that coverage yet. I think the case that's important is:

• Parent SA rekeys
• Old parent SA is replaced and expired
• (parent-less) child rekeys and has to find the new parent SA to do so

mh

-- Martin Hicks P.Eng. | mort@bork.org Bork Consulting Inc. | +1 (613) 266-2296

[mohicks]

The additional debug print that MCR added also answers the question re: the unit test. There are currently no unit tests where the parent SA rekeys and then a child rekeys.

[mcr]

I'll address this comment here because I don't see it on the Pull Request / Review. I think we should fork this as a separate bug/task.

I don't really care how the work is tracked. I just want a way to exercise these code paths.

[shussain]

Cherry-picked commits to 2.6.52dev branch