search

xem / W

A micro WebGL2 framework with a ton of features
https://xem.github.io/W
331 stars 23 forks source link

Remove unused parameters from setState #23

Open Lukenickerson opened 9 months ago

Lukenickerson commented 9 months ago

As far as I can tell, the setState function (https://github.com/xem/W/blob/gh-pages/w.js#L131) only uses the state, type, and texture parameters, and does not use i, normal = [], A, B, C, Ai, Bi, Ci, AB, BC.

@xem -- Can these be safely removed?

xem commented 9 months ago

Oh, nice catch! It seems so.

xem commented 9 months ago

Hi Luke, I saw your video and it's amazing. Let me know if you want to be an official contributor of this repo (with write access), or chat with me on telegram, whatsapp? I'd be happy to help you and improve W at the same time.

Lukenickerson commented 9 months ago

Glad you like the video. Sure, I'd love to be a contributor! I'm also on Discord and WhatsApp.

xem commented 9 months ago

I added you :) I've not coded a lot the past year, but slowly getting back to it. There are features I'd like to add in W, like shadow casting, bump mapping, skybox, ... I may start prototyping things like this in the future. In the meantime, I'm here if you have questions or critics, and I can't wait for the video #2 !